Simplify ML processor form when interface is defined #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> (cherry picked from commit 47d59fe) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
saimedhi
pushed a commit
that referenced
this pull request
Mar 13, 2025
(cherry picked from commit 47d59fe) Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplifies the controls & form components for ML processors when the underlying model has a defined interface. Make the inputs & outputs readonly, and prevent adding/deleting entries. The main idea is that if a model has a defined interface, add more guardrails to prevent user confusion from creating invalid/unnecessary mappings.
Other small improvements:
Demo video, showing the cleaned up form when an interface is defined. Note there is no way to edit the input or output field names, no way to delete any input/output entries, and no way to add any input/output entries, when compared to a model with no defined interface:
screen-capture.29.webm
Issues Resolved
N/A
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.