Fix missed UI autofilling after JSON Lines change #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
added
bug
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
ohltyler
changed the title
saimedhi
approved these changes
Mar 12, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 12, 2025
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> (cherry picked from commit 6cefa2a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
saimedhi
pushed a commit
that referenced
this pull request
Mar 12, 2025
(cherry picked from commit 6cefa2a) Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a few missed edge cases where the doc parsing failed after the switch to JSONLines format. Also moves common logic into a helper fn.
Demo video showing the autofilling with different inputs:
screen-capture.28.webm
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.