Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist state across Inspector tab switches; add presets dropdown #671

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Mar 11, 2025

Description

Currently, a lot of the search-related state is localized to the tab component, and as a consequence gets reset across tab switches and re-renderings. This PR moves the following state params to the parent Tools component to prevent lost data:

  • query request
  • query params
  • query response

Also, adds a query preset dropdown consistent with the other locations it is available (in the edit query modal and override query modals).

Demo video showing the persisted state:

screen-capture.27.webm

Screenshot showing the query preset in the panel:
presets-dropdown

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler ohltyler added the enhancement New feature or request label Mar 11, 2025
@ohltyler ohltyler marked this pull request as draft March 11, 2025 21:49
@ohltyler ohltyler marked this pull request as ready for review March 11, 2025 22:24
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler ohltyler changed the title Persist state across Inspector tab switches Persist state across Inspector tab switches; add presets dropdown Mar 11, 2025
@ohltyler ohltyler merged commit 21ddd80 into opensearch-project:2.x Mar 12, 2025
5 of 6 checks passed
@ohltyler ohltyler deleted the persist-query branch March 12, 2025 15:14
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 12, 2025
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
(cherry picked from commit 21ddd80)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler pushed a commit that referenced this pull request Mar 12, 2025
…) (#675)

(cherry picked from commit 21ddd80)

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport main enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants