Persist state across Inspector tab switches; add presets dropdown #671
+124
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
changed the title
saimedhi
approved these changes
Mar 12, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 12, 2025
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> (cherry picked from commit 21ddd80) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, a lot of the search-related state is localized to the tab component, and as a consequence gets reset across tab switches and re-renderings. This PR moves the following state params to the parent
Toolscomponent to prevent lost data:Also, adds a query preset dropdown consistent with the other locations it is available (in the edit query modal and override query modals).
Demo video showing the persisted state:
screen-capture.27.webm
Screenshot showing the query preset in the panel:
Issues Resolved
N/A
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.