Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new index mappings if selecting from existing index #670

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

ohltyler
Copy link
Member

Description

This PR updates the new index mappings to match that of the existing index, if "select from an existing index" option is selected when fetching the source data. Persists any pre-configured vector field mappings, if found. For example, suppose there is a my_vector field of type knn_vector. If source data is selected and the overall index mappings are updated, my_vector is still persisted. See demo video below.

Also cleans up some unnecessary logic of updating the input map based on the source data selection, which could cause bugs under certain edge cases.

Demo video:

screen-capture.26.webm

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler ohltyler merged commit 101472b into opensearch-project:2.x Mar 12, 2025
7 of 10 checks passed
@ohltyler ohltyler deleted the automated-mappings branch March 12, 2025 15:09
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 12, 2025
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
(cherry picked from commit 101472b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler pushed a commit that referenced this pull request Mar 12, 2025
(cherry picked from commit 101472b)

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport main bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants