Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new RAG + hybrid search preset #665

Merged
merged 5 commits into from
Mar 10, 2025

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Mar 6, 2025

Description

Onboard a new preset, combining RAG + hybrid search. The same as the RAG + vector search preset, but changing the overridden query in the ML search request processor from knn -> hybrid (match + knn), and adding a corresponding normalization processor.

Also fixes an edge case of running partial pipelines via advanced transforms, not bucketing the phase results processor (currently just the normalization processor) that would cause failures when fetching the interim data.

Demo video showing the new preset up and running in few clicks:

screen-capture.25.webm

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler added 2 commits March 6, 2025 11:30
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
…rectly

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler ohltyler marked this pull request as ready for review March 6, 2025 20:21
@ohltyler
Copy link
Member Author

ohltyler commented Mar 6, 2025

IT results all passing:

       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  plugins/dashboards-flow-framework/c      02:41        6        6        -        -        - │
  │    reate_workflow_spec.js                                                                      │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        02:41        6        6        -        -        -  

Copy link
Collaborator

@saimedhi saimedhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ohltyler added 2 commits March 6, 2025 15:56
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler
Copy link
Member Author

Removed RAG with lexical search preset.

@ohltyler ohltyler added enhancement New feature or request backport main labels Mar 10, 2025
@ohltyler ohltyler merged commit 3ff7b00 into opensearch-project:2.x Mar 10, 2025
7 of 8 checks passed
@ohltyler ohltyler deleted the hybrid-rag branch March 10, 2025 15:32
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 10, 2025
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
(cherry picked from commit 3ff7b00)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler pushed a commit that referenced this pull request Mar 10, 2025
(cherry picked from commit 3ff7b00)

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport main enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants