Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default queries; update quick config fields; misc updates #660

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Mar 4, 2025

Description

This PR has a variety of bug fixes and general improvements.

  • update the default query from term to match for the presets
  • only show the embedding length field in the quick-configure modal if the selected embedding model has an unknown / not persisted length. otherwise, hide the form field to prevent unnecessary user confusion/complexity.
  • add the same gear icon to update workflow name/description when useNewHomePage=true. This was missing before, it is now consistent with experience when useNewHomePage=false.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler ohltyler added bug Something isn't working enhancement New feature or request backport main labels Mar 4, 2025
@ohltyler ohltyler marked this pull request as draft March 4, 2025 18:26
ohltyler added 2 commits March 4, 2025 10:48
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler ohltyler marked this pull request as ready for review March 4, 2025 19:44
Copy link
Collaborator

@saimedhi saimedhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saimedhi saimedhi merged commit c729bec into opensearch-project:2.x Mar 5, 2025
5 of 6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 5, 2025
* Change default to match query

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Only show embedding field in quick config if unknown

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* add gear in header for newhomepage

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

---------

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
(cherry picked from commit c729bec)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
saimedhi pushed a commit that referenced this pull request Mar 5, 2025
… (#661)

* Change default to match query



* Only show embedding field in quick config if unknown



* add gear in header for newhomepage



---------


(cherry picked from commit c729bec)

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ohltyler ohltyler deleted the fixes-5 branch March 5, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport main bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants