[Backport main] Add functional buttons in form headers; fix query parse bug #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add test flow button in form headers Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Refactor flyout into standalone component Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * More refactoring and layout updates Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Move datasourceversion fetching into custom reusable hook Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Remove unnecessary loading state param Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * More refactoring; set up multi-resource flyout Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Get multi resource flyout working and entrypoints in main flow Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Fix regex replacement Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Add examples for ingest and search Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Propagate runtime props to flyout content Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> * Propagate in existing resources tab alsog Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> --------- Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com> (cherry picked from commit 4bfd70c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
bug
opensearch-trigger-bot
bot
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
saimedhi
approved these changes
Feb 28, 2025
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-658-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 34ff91e18ee180303e302d4b2319a406d4de64a9
# Push it to GitHub
git push --set-upstream origin backport/backport-658-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-flow-framework/backport-2.xThen, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 4bfd70c from #649.