Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed local cluster bug and added datasource version compatibility check before importing workflows #646

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

saimedhi
Copy link
Collaborator

@saimedhi saimedhi commented Feb 26, 2025

Description

  • Added datasource version compatibility check before importing workflows.
    • case 1 MDS disabled, import workflow compatibility validate check is not present.
    • case 2 compatibility array is not given in import workflow template, validate check is not present.
    • case 3 MDS enabled, when we have compatibility array defined in import workflow template, validation is done to verify if datasource version is present with in the range of compatibility array
screen-capture.50.webm
screen-capture.48.webm

continuation MDS disabled:

screen-capture.51.webm

Issues Resolved

closes #626

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…eck before importing workflows

Signed-off-by: saimedhi <saimedhi@amazon.com>
…eck before importing workflows

Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi saimedhi requested a review from ohltyler February 26, 2025 21:57
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great improvements.

@saimedhi saimedhi merged commit 45968d5 into opensearch-project:main Feb 26, 2025
7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 26, 2025
…eck before importing workflows (#646)

* Fixed local cluster bug and added datasource version compatibility check before importing workflows

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Fixed local cluster bug and added datasource version compatibility check before importing workflows

Signed-off-by: saimedhi <saimedhi@amazon.com>

---------

Signed-off-by: saimedhi <saimedhi@amazon.com>
(cherry picked from commit 45968d5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
saimedhi pushed a commit that referenced this pull request Feb 26, 2025
…eck before importing workflows (#646) (#650)

* Fixed local cluster bug and added datasource version compatibility check before importing workflows



* Fixed local cluster bug and added datasource version compatibility check before importing workflows



---------


(cherry picked from commit 45968d5)

Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Local cluster is not displaying the deployed models as expected.
2 participants