Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes XIII #630

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Bug fixes XIII #630

merged 2 commits into from
Feb 18, 2025

Conversation

saimedhi
Copy link
Collaborator

Description

Fixed the following issues.

  • when switching between datasources loading state should be displayed instead of delay.
  • “Transform query” section still shows up for a moment before being hidden when navigated to search flow.
screen-capture.43.webm

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saimedhi
Bug fixes XIII
2d9e435 
Signed-off-by: saimedhi <saimedhi@amazon.com>
ohltyler
ohltyler requested changes Feb 18, 2025
View reviewed changes
public/pages/workflow_detail/workflow_inputs/search_inputs/search_inputs.tsx
@@ -29,7 +29,7 @@ interface SearchInputsProps {
export function SearchInputs(props: SearchInputsProps) {
const dispatch = useAppDispatch();
const dataSourceId = getDataSourceId();
const [showTransformQuery, setShowTransformQuery] = useState(true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm, in the case of MDS disabled, this still gets switched to true? Need to make sure this doesn't introduce any regression.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added condition for MDS disabled case.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added condition for MDS disabled case.

MDS enabled: datasource 2.19
Screenshot 2025-02-18 at 2 57 06 PM

MDS enabled: datasource 2.17
Screenshot 2025-02-18 at 2 54 43 PM

MDS disabled:
Screenshot 2025-02-18 at 2 47 10 PM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is now doing the inverse of the original change, does this cause the reverse issue of not showing the Transform query section for a split second now?

Copy link
Member

@ohltyler ohltyler Feb 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you send a video of loading the page with MDS disabled, for example?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen-capture.44.webm

@saimedhi
Bug fixes XIII
5ec2bd0 
Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi saimedhi requested a review from ohltyler February 18, 2025 23:24
ohltyler
ohltyler approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM

@saimedhi saimedhi merged commit 860a23d into opensearch-project:main Feb 18, 2025
7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 18, 2025
@github-actions
Bug fixes XIII (#630)
33f498d 
* Bug fixes XIII

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Bug fixes XIII

Signed-off-by: saimedhi <saimedhi@amazon.com>

---------

Signed-off-by: saimedhi <saimedhi@amazon.com>
(cherry picked from commit 860a23d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 18, 2025
Merged
saimedhi pushed a commit that referenced this pull request Feb 19, 2025
@opensearch-trigger-bot @github-actions
Bug fixes XIII (#630) (#631)
26f6eae 
* Bug fixes XIII



* Bug fixes XIII



---------


(cherry picked from commit 860a23d)

Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohltyler ohltyler ohltyler approved these changes

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@joshpalis joshpalis Awaiting requested review from joshpalis joshpalis is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

@minalsha minalsha Awaiting requested review from minalsha minalsha is a code owner

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saimedhi @ohltyler