Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added popover to display links to suggested models #625

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

saimedhi
Copy link
Collaborator

@saimedhi saimedhi commented Feb 18, 2025

Description

  • Added popover to display links to suggested models
  • Included both Embedding and Large Language model examples.
  • Added Semantic Search Template Query Preset.
  • Added documentation for DeepSeek, OpenAI GPT 3.5, Cohere Embed Models.

Semantic Search Template Query Preset:
Screenshot 2025-02-17 at 4 06 47 PM

Semantic Search Neural Query Preset:
Screenshot 2025-02-17 at 4 06 32 PM

Screenshot 2025-02-17 at 4 00 07 PM

Screenshot 2025-02-17 at 4 48 46 PM

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: saimedhi <saimedhi@amazon.com>
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting close, let's be sure to test any added models and make sure they work smoothly on the UI, so we keep a high standard on our documentation.

Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi saimedhi marked this pull request as draft February 20, 2025 23:28
Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi
Copy link
Collaborator Author

saimedhi commented Feb 20, 2025

  • Followed the documentation added in this PR for creating below connectors and models.

Cohere Embed Model testing:

screen-capture.45.webm

Deepseek Model

screen-capture.46.webm

OpenAI GPT 3.5

screen-capture.47.webm

Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi saimedhi marked this pull request as ready for review February 21, 2025 00:39
@saimedhi saimedhi requested a review from ohltyler February 21, 2025 00:46
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great to see the quick integration with the latest models.

@ohltyler ohltyler merged commit ccfbb9e into opensearch-project:main Feb 21, 2025
7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 21, 2025
Signed-off-by: saimedhi <saimedhi@amazon.com>
(cherry picked from commit ccfbb9e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler pushed a commit that referenced this pull request Feb 21, 2025
(cherry picked from commit ccfbb9e)

Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants