Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving and expanding functionality checks for the workflow_detail page #360

Merged
merged 12 commits into from
Sep 11, 2024
Merged

Improving and expanding functionality checks for the workflow_detail page #360

merged 12 commits into from
Sep 11, 2024

Conversation

saimedhi
Copy link
Collaborator

@saimedhi saimedhi commented Sep 10, 2024 •
edited
Loading

Description

Improving and expanding functionality checks for the workflow_detail page. Added tests for below functionalities.

  • The "Create an ingest pipeline" option is selected by default
  • The "Skip ingestion pipeline" option is disabled by default
  • The "Run ingestion" button is enabled by default
  • The "Search pipeline >" button is disabled by default
  • Clicking the "close" button goes back to the list page
  • Clicking the "export" button opens the export component
  • Collapsing the "Tools" panels hides those components
  • The default components in the ReactFlow workspace are visible. Default- Visual.

Issues Resolved

Related to #95

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saimedhi
Improving and expanding functionality checks for the workflow_detail …
7d84a15 
…page

Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi
Improving and expanding functionality checks for the workflow_detail …
169a8c4 
…page

Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi saimedhi marked this pull request as ready for review September 10, 2024 12:49
@ohltyler ohltyler added the test label Sep 10, 2024
@saimedhi saimedhi marked this pull request as draft September 11, 2024 03:04
@saimedhi
Improving and expanding functionality checks for the workflow_detail …
202de88 
…page

Signed-off-by: saimedhi <saimedhi@amazon.com>
saimedhi and others added 8 commits September 10, 2024 20:13
@saimedhi
Improving and expanding functionality checks for the workflow_detail …
cd96bdc 
…page

Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi
Improving and expanding functionality checks for the workflow_detail …
46cb43f 
…page

Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi
Improving and expanding functionality checks for the workflow_detail …
3e02ebf 
…page

Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi
Merge branch 'tests_5' into tests_5_copy2
e3252aa 
Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
@saimedhi
Merge pull request #8 from saimedhi/tests_5_copy2
013f0b7 
Improving and expanding functionality checks for the workflow_detail page
@saimedhi
Merge branch 'main' into tests_5
74fc7d3 
Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
@saimedhi
Improving and expanding functionality checks for the workflow_detail …
6d4ad32 
…page

Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi
Improving and expanding functionality checks for the workflow_detail …
9a770a8 
…page

Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi saimedhi marked this pull request as ready for review September 11, 2024 19:10
@saimedhi
Merge branch 'main' into tests_5
f1f8fe2 
Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
@saimedhi saimedhi requested a review from ohltyler September 11, 2024 19:32
ohltyler
ohltyler approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saimedhi saimedhi merged commit 7e704d9 into opensearch-project:main Sep 11, 2024
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 11, 2024
@saimedhi @github-actions
Improving and expanding functionality checks for the workflow_detail …
597aa5d 
…page (#360)

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <saimedhi@amazon.com>

---------

Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
(cherry picked from commit 7e704d9)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 11, 2024
Merged
saimedhi added a commit that referenced this pull request Sep 11, 2024
@opensearch-trigger-bot @saimedhi
Improving and expanding functionality checks for the workflow_detail …
d669c10 
…page (#360) (#366)

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <saimedhi@amazon.com>

* Improving and expanding functionality checks for the workflow_detail page

Signed-off-by: saimedhi <saimedhi@amazon.com>

---------

Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
(cherry picked from commit 7e704d9)

Co-authored-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohltyler ohltyler ohltyler approved these changes

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@joshpalis joshpalis Awaiting requested review from joshpalis joshpalis is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

@minalsha minalsha Awaiting requested review from minalsha minalsha is a code owner

Assignees
No one assigned
Labels
backport 2.x dependencies test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saimedhi @ohltyler