Adding unit tests for new_workflow, workflow_list, import_workflow_modal components #317
+122
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimedhi
force-pushed
the
test_workflow_list
branch
from
60dab8b to
3bcc86d
Compare
saimedhi
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz,
jackiehanyang and
minalsha
as code owners
|
I'll be adding additional tests to the above components in my upcoming PRs to ensure better coverage |
Signed-off-by: saimedhi <saimedhi@amazon.com>
saimedhi
force-pushed
the
test_workflow_list
branch
from
3bcc86d to
06ee915
Compare
ohltyler
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Thanks for setting up. For more examples of detailed coverage, you can look at the AD detector list page tests. In general, we should test some basic functionality of the pages. For example, on the list page, test different states (empty / no workflow state, populated state, populated and filtered state, etc.), and that the components within the page are rendering as expected.
amitgalitz
approved these changes
Aug 29, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
Signed-off-by: saimedhi <saimedhi@amazon.com> (cherry picked from commit 7cf2ac2)
ohltyler
pushed a commit
that referenced
this pull request
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding unit tests for new_workflow, workflow_list, import_workflow_modal components
Issues Resolved
Related to #96 , #97
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.