Observability otel demo #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
lezzago
requested review from
seraphjiang,
zhongnansu,
kristenTian,
Flyingliuhub,
BionIT,
zengyan-amazon and
himanshu1214
as code owners
Flyingliuhub
reviewed
Dec 6, 2023
| sink: | ||
| - opensearch: | ||
| hosts: ["https://opensearch-cluster-leader.default.svc:9200"] | ||
| username: "admin" |
There was a problem hiding this comment.
Can we change to some variable or placeholder here? Thanks
Flyingliuhub
reviewed
Dec 6, 2023
| - opensearch: | ||
| hosts: ["https://opensearch-cluster-leader.default.svc:9200"] | ||
| username: "admin" | ||
| password: "admin" |
There was a problem hiding this comment.
Can we change to some variable or placeholder here? and other location. Thanks
Flyingliuhub
reviewed
Dec 6, 2023
| METRICS_STORAGE_TYPE: "prometheus" | ||
| SPAN_STORAGE_TYPE: "opensearch" | ||
| ES_TAGS_AS_FIELDS_ALL: "true" | ||
| ES_USERNAME: "admin" |
There was a problem hiding this comment.
same here, can we change to some variable or placeholder here? Thanks
Flyingliuhub
reviewed
Dec 6, 2023
| - name: OPENSEARCH_HOST | ||
| value: "opensearch-cluster-leader.default.svc" | ||
| - name: OPENSEARCH_USER | ||
| value: "admin" |
There was a problem hiding this comment.
same here for changing to some variable or placeholder here? Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an update on the #185 PR
Issues Resolved
#180
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.