Remove resource config validation for github-events-to-s3 call #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshien
requested review from
getsaurabh02,
peterzhuamazon,
gaiksaya,
prudhvigodithi and
nhtruong
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 10 10
Lines 180 181 +1
Branches 25 25
=======================================
+ Hits 179 180 +1
Misses 1 1 ☔ View full report in Codecov by Sentry. |
|
Hi @bshien rebase on main please I just update the main branch yesterday. Thanks. |
Signed-off-by: Brandon Shien <bshien@amazon.com>
| if (!(await validateResourceConfig(app, context, resource))) return; | ||
| export default async function githubEventsToS3(app: Probot, context: any): Promise<void> { | ||
| // Removed validateResourceConfig to let this function listen on all repos, and filter for only the repos that are public. | ||
| // This is done so when a new repo is made public, this app can automatically start processing its events. |
There was a problem hiding this comment.
Please add one more comment along the lines of:
This is only for the s3 data lake specific case, everything else should still specify repos required to be listened in resource config.
| // Removed validateResourceConfig to let this function listen on all repos, and filter for only the repos that are public. | ||
| // This is done so when a new repo is made public, this app can automatically start processing its events. | ||
| // if (!(await validateResourceConfig(app, context, resource))) return; | ||
| if (context.payload.repository?.private === false) { |
There was a problem hiding this comment.
Wonder if we need an else branch to log which repo is skipped due to being private.
|
|
||
| await githubEventsToS3(app, context); | ||
|
|
||
| expect(mockS3Client.send).not.toHaveBeenCalledWith(expect.any(PutObjectCommand)); |
There was a problem hiding this comment.
If you add an app.log.error for private repo then you can check if that is being called when repo is private.
Signed-off-by: Brandon Shien <bshien@amazon.com>
peterzhuamazon
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove resource config validation in github-events-to-s3 call to allow the app to listen on events from all repos, then filter only for public repos. This way, when a new repo is added, the app can start acting on the new repo's events immediately.
Additionally ran a
prettier --write .Issues Resolved
Part of opensearch-project/opensearch-metrics#76
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.