Increase category field limit from 2 to 5 for time series splitting #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddhartha Bingi <sidbingi@amazon.com>
added 2 commits
February 21, 2025 00:54
Signed-off-by: Siddhartha Bingi <sidbingi@amazon.com>
Signed-off-by: Siddhartha Bingi <sidbingi@amazon.com>
amitgalitz
reviewed
Feb 24, 2025
| @@ -155,7 +156,7 @@ export function CategoryField(props: CategoryFieldProps) { | |||
| onChange={(options) => { | |||
| const selection = options.map((option) => option.label); | |||
| if (!isEmpty(selection)) { | |||
| if (selection.length <= 2) { | |||
| if (selection.length <= 5) { | |||
There was a problem hiding this comment.
would it be possible that we base this number on our plugin setting and we change the default to 5 there as max?
https://github.com/opensearch-project/anomaly-detection/blob/main/src/main/java/org/opensearch/ad/settings/ADNumericSetting.java#L40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.