[Backport 2.x] Adding feature direction and moving suppression rules to each feature #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opensearch-project#960) * adding feature direction and moving suppression rules to each feature Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * fixing bug where two conditions didn't display Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * improve error handling Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * style changes and removing extra errors Signed-off-by: Amit Galitzky <amgalitz@amazon.com> * remove console log Signed-off-by: Amit Galitzky <amgalitz@amazon.com> --------- Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
amitgalitz
requested review from
ohltyler,
kaituo,
jackiehanyang,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #966 +/- ##
==========================================
+ Coverage 52.36% 53.82% +1.46%
==========================================
Files 168 170 +2
Lines 6541 6946 +405
Branches 1336 1426 +90
==========================================
+ Hits 3425 3739 +314
- Misses 2718 2777 +59
- Partials 398 430 +32 ☔ View full report in Codecov by Sentry. |
kaituo
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Porting #960 to 2.x with a fixed snapshot due to difference in enable flatten index between main and 2.x
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.