Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Look&Feel] Use smaller and compressed varients of buttons and form components #826

Merged
merged 13 commits into from
Aug 17, 2024
Merged

[Look&Feel] Use smaller and compressed varients of buttons and form components #826

merged 13 commits into from
Aug 17, 2024

Conversation

AMoo-Miki
Copy link
Contributor

@AMoo-Miki AMoo-Miki commented Aug 2, 2024 •
edited
Loading

Description

Replace instances of EuiButton that don't have an explicit sizing attribute to EuiSmallButton*.
Replace instances of Eui<form elements> that don't have density attributes to EuiCompressed<form elements>.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AMoo-Miki
Copy link
Contributor Author

The tests will fail on EuiCompressedSuperDatePicker until OUI 1.8.2 is introduced in OSD; will leave the PR open while waiting for that.

@jackiehanyang
Copy link
Collaborator

Thanks for the change Miki! Will leave the pr open untils OUI 1.8.2 is introduced in OSD and all CI passes

@jackiehanyang jackiehanyang mentioned this pull request Aug 9, 2024
Merged
4 tasks
@jackiehanyang jackiehanyang changed the title Use smaller and compressed varients of buttons and form components [Look&Feel] Use smaller and compressed varients of buttons and form components Aug 9, 2024
AMoo-Miki added 12 commits August 16, 2024 15:45
@AMoo-Miki
Use EuiSmallButton
8f98ce8 
Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki
Use EuiSmallButtonIcon
d1fb930 
Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki
Use EuiSmallButtonEmpty
cb78bcc 
Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki
Use EuiCompressedFormRow
3d569d7 
Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki
Use EuiCompressedField*
54c5542 
Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki
Use EuiCompressedSelect and EuiCompressedSuperSelect
d00a47d 
Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki
Use EuiCompressedCheckbox and EuiCompressedCheckboxGroup
451b108 
Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki
Use EuiCompressedSwitch
55b48c1 
Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki
Use EuiCompressedEuiTextArea
434bce9 
Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki
Use EuiCompressedComboBox
3fbb483 
Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki
Use EuiCompressedSuperDatePicker
1b958c2 
Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki
Update snapshots
a69bc10 
Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki
Update snapshots and tests
b3efdc1 
Signed-off-by: Miki <miki@amazon.com>
@jackiehanyang jackiehanyang merged commit 3203e43 into opensearch-project:main Aug 17, 2024
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 17, 2024
@AMoo-Miki @github-actions
[Look&Feel] Use smaller and compressed varients of buttons and form c…
97504c2 
…omponents (#826)

(cherry picked from commit 3203e43)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 17, 2024
Merged
ohltyler pushed a commit that referenced this pull request Aug 19, 2024
@opensearch-trigger-bot @AMoo-Miki
[Look&Feel] Use smaller and compressed varients of buttons and form c…
95cd499 
…omponents (#826) (#842)

(cherry picked from commit 3203e43)

Co-authored-by: Miki <miki@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackiehanyang jackiehanyang jackiehanyang approved these changes

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@kaituo kaituo Awaiting requested review from kaituo kaituo is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@sean-zheng-amazon sean-zheng-amazon Awaiting requested review from sean-zheng-amazon sean-zheng-amazon is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@joshpalis joshpalis Awaiting requested review from joshpalis joshpalis is a code owner

Assignees
No one assigned
Labels
backport 2.x v2.17.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AMoo-Miki @jackiehanyang @sean-zheng-amazon