update snapshots for 2.12 #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
jackiehanyang
requested review from
ohltyler,
kaituo,
amitgalitz,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
joshpalis
approved these changes
Feb 15, 2024
|
@joshpalis let's hold off on approvals until CIs are passing. For 2.12 we should not have failing UT, and don't want to merge changes if it breaks infra builds |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.12 #690 +/- ##
=======================================
Coverage ? 50.31%
=======================================
Files ? 166
Lines ? 5593
Branches ? 1057
=======================================
Hits ? 2814
Misses ? 2508
Partials ? 271 ☔ View full report in Codecov by Sentry. |
ohltyler
approved these changes
Feb 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
Signed-off-by: Jackie Han <jkhanjob@gmail.com> (cherry picked from commit 0268447)
88 tasks
jackiehanyang
added a commit
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update snapshots for 2.12
Issues Resolved
[List any issues this PR will resolve]
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.