Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to run RemoteStoreIT with S3 integration #17578

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ashking94
Copy link
Member

Description

As part of #15333, read context in RemoteStoreRefreshListener is changed from DEFAULT to READONCE. This led to failures with java.lang.WrongThreadException: Attempted access outside owning thread during segments upload to remote store esp with s3-repository plugin.
Remote store integ tests use FsRepository but as the implementation changes for repository-s3, ideally we need to integ tests that talk directly to s3. We will take this up as a follow-up task.

In this PR, we are adding the main RemoteStoreIT is being run with local FS and S3 as well.

Check List

  • Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for a50b2f8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 44994aa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 1ea0a59: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Copy link
Contributor

❌ Gradle check result for 0dfb787: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 0dfb787: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 0dfb787: SUCCESS

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.37%. Comparing base (ffa46ca) to head (0dfb787).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...index/translog/RemoteFsTimestampAwareTranslog.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17578      +/-   ##
============================================
- Coverage     72.43%   72.37%   -0.07%     
+ Complexity    65721    65664      -57     
============================================
  Files          5311     5311              
  Lines        304941   304937       -4     
  Branches      44228    44226       -2     
============================================
- Hits         220890   220686     -204     
- Misses        65952    66125     +173     
- Partials      18099    18126      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants