-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to run RemoteStoreIT with S3 integration #17578
base: main
Are you sure you want to change the base?
Conversation
69d4564
to
793eef2
Compare
793eef2
to
a50b2f8
Compare
❌ Gradle check result for a50b2f8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
a50b2f8
to
44994aa
Compare
❌ Gradle check result for 44994aa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
44994aa
to
1ea0a59
Compare
❌ Gradle check result for 1ea0a59: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ashish Singh <ssashish@amazon.com>
1ea0a59
to
0dfb787
Compare
❌ Gradle check result for 0dfb787: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 0dfb787: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17578 +/- ##
============================================
- Coverage 72.43% 72.37% -0.07%
+ Complexity 65721 65664 -57
============================================
Files 5311 5311
Lines 304941 304937 -4
Branches 44228 44226 -2
============================================
- Hits 220890 220686 -204
- Misses 65952 66125 +173
- Partials 18099 18126 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
As part of #15333, read context in RemoteStoreRefreshListener is changed from
DEFAULT
toREADONCE
. This led to failures withjava.lang.WrongThreadException: Attempted access outside owning thread
during segments upload to remote store esp with s3-repository plugin.Remote store integ tests use FsRepository but as the implementation changes for repository-s3, ideally we need to integ tests that talk directly to s3. We will take this up as a follow-up task.
In this PR, we are adding the main RemoteStoreIT is being run with local FS and S3 as well.
Check List
[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.