-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search backpressure service check for query group tasks #17576
base: main
Are you sure you want to change the base?
Add search backpressure service check for query group tasks #17576
Conversation
❌ Gradle check result for 3dcb827: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 3dcb827: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for d7e462b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
d7e462b
to
d0f9e14
Compare
❌ Gradle check result for d0f9e14: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
This change is to address the bug when search backpressure service is gathering the node stats and there are
QueryGroupTask
s in the system which doesn't have the queryGroupId set. In this case there will be a NPE thrown for node stats due to this line.But this will only happen for 2.x versions since they don't have the scroll API changes for setting the queryGroupId #17169. We had to remove the API change because of the backward compatibility failure which was blocking the merge but later maintainers removed the check for internalApi annotated classes since they are not meant to be used outside of opensearch core.
I will also add that change in 2.x subsequently.
Related Issues
Resolves #17518 (comment)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.