Renaming the node role search to warm

[vinaykpud]

In this PR we are renaming the existing Node "Search Role" to "Warm Role"

Description

This is done based on the decision taken as part of the discussion in this thread: #17422 (comment)

Related Issues

Related to #15306
Related to #17422

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR [created] [DOC] Rename Search node role to Warm node role for searchable snapshots documentation-website#9392

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[mch2]

This is a straight rename correct? It does not resolve #17422 ?

[github-actions]

❌ Gradle check result for 835fd60: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[vinaykpud]

This is a straight rename correct? It does not resolve #17422 ?

Yes, Do you want me to add a new issue for this?

[github-actions]

❌ Gradle check result for b0d026a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for b0d026a: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.41%. Comparing base (ffa46ca) to head (b0d026a).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
.../java/org/opensearch/env/NodeRepurposeCommand.java	81.81%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #17573      +/-   ##
============================================
- Coverage     72.43%   72.41%   -0.02%     
- Complexity    65721    65728       +7     
============================================
  Files          5311     5311              
  Lines        304941   304937       -4     
  Branches      44228    44226       -2     
============================================
- Hits         220890   220829      -61     
- Misses        65952    66040      +88     
+ Partials      18099    18068      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[andrross]

Let's make sure this aligns with what @gbbafna mentioned here before merging.

We'd generally want to do a deprecation cycle before just replacing a term like this. However, it does appear that search was a bit of a misnomer and it is not in wide use beyond searchable snapshots, so I'm not totally opposed with doing this to unblock the usage of the search role where it might actually make more sense.

[gbbafna]

@vinaykpud : Can we verify if we upgrade the cluster from 2.x to 3.0 with this change, searchable snapshots continue to work ? There might be few nuances here like changing the cluster-manager first . Want to make sure that rolling restarts works with this change