Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added stats for phase results processors at search pipeline level #17559

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

martin-gaievski
Copy link
Member

@martin-gaievski martin-gaievski commented Mar 9, 2025

Description

Adding stats for search phase result processor type. Today we do not collect any metric for this processor type, while for request and response processor types those metrics are collected and returned with the node level stats response.

Sample request, no changes there

GET /_nodes/stats/search_pipeline

sample response, section phase_results_processors is added with this PR:

        "XzOye699Q-SnVrFcJ-b8Tg": {
            "timestamp": 1741224352625,
            "name": "integTest-0",
            "transport_address": "127.0.0.1:9300",
            "host": "127.0.0.1",
            "ip": "127.0.0.1:9300",
            "roles": [
                "cluster_manager",
                "data",
                "ingest",
                "remote_cluster_client"
            ],
            "attributes": {
                "testattr": "test",
                "shard_indexing_pressure_enabled": "true"
            },
            "search_pipeline": {
                "total_request": {
                    "count": 240,
                    "time_in_millis": 547,
                    "current": 0,
                    "failed": 0
                },
                "total_response": {
                    "count": 0,
                    "time_in_millis": 0,
                    "current": 0,
                    "failed": 0
                },
                "pipelines": {
                    "nlp-min-max-arithmetic-search-pipeline": {
                        "request": {
                            "count": 240,
                            "time_in_millis": 547,
                            "current": 0,
                            "failed": 0
                        },
                        "response": {
                            "count": 0,
                            "time_in_millis": 0,
                            "current": 0,
                            "failed": 0
                        },
                        "request_processors": [],
                        "response_processors": [],
                        "phase_results_processors": [
                            {
                                "normalization-processor": {
                                    "type": "normalization-processor",
                                    "stats": {
                                        "count": 240,
                                        "time_in_millis": 545,
                                        "current": 0,
                                        "failed": 0
                                    }
                                }
                            }
                        ]
                    }
                }
            }
        }, 

Related Issues

#17558

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
@martin-gaievski martin-gaievski force-pushed the add_stats_phase_results_processor branch from a16e3fe to ffeb095 Compare March 9, 2025 22:24
Copy link
Contributor

github-actions bot commented Mar 9, 2025

❌ Gradle check result for ffeb095: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for ffeb095: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Copy link
Contributor

❌ Gradle check result for 7bf703b: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 7bf703b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant