Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for stale writer correctness with pinned timestamp snapshots #17536

Closed
wants to merge 0 commits into from

Conversation

ashking94
Copy link
Member

Description

This PR adds a unit test for handling the case of choosing the correct metadata file when there are metadata files created by stale writer which has higher timestamp than correct writer (which has higher primary term) but below the pinned timestamp. This test checks that the timestamp picked is always the one with highest primary term.

Check List

  • Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Mar 6, 2025

❌ Gradle check result for 10a24b1: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Mar 7, 2025

❌ Gradle check result for 10a24b1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ashking94
Copy link
Member Author

❌ Gradle check result for 10a24b1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Unrelated failures:
Test Result (2 failures / -4)
org.opensearch.remotestore.RemoteStorePinnedTimestampsGarbageCollectionIT.testLiveIndexNoPinnedTimestamps
org.opensearch.snapshots.SharedClusterSnapshotRestoreIT.testSnapshotFileFailureDuringSnapshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants