[Backport 2.x] [rule based autotagging] add attribute value store #17441
Conversation
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* [rule based autotagging] add attribute value store Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add CHANGELOG entry Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * make the store interface generic Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * run spotless apply Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add missing javadoc Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * improve javadoc for attribute value store Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * improve binary search bisecting expression Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add licenses directory Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> (cherry picked from commit 4648c3f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for 3312432: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 3312432: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 3312432: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Cardinality tests seems to be failing consistently: |
|
I see that the following PRs are also failing due to same test suite
There might be some other underlying reason for failures. |
|
@kaushalmahi12 Could it be because #17380 is not in 2.19? I am seeing this error:
|
|
BWC failures were because #17419 was merged into 2.19 before it was merged into 2.x. |
|
❕ Gradle check result for c684bfe: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #17441 +/- ##
============================================
+ Coverage 71.92% 71.95% +0.02%
- Complexity 65942 65968 +26
============================================
Files 5341 5342 +1
Lines 307223 307250 +27
Branches 44838 44842 +4
============================================
+ Hits 220981 221083 +102
+ Misses 67788 67710 -78
- Partials 18454 18457 +3 ☔ View full report in Codecov by Sentry. |
Backport 4648c3f from #17342.