Introduce execution_hint for Cardinality aggregation (#17312) - backport to 2.19
#17420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oject#17312) - backport to 2.19 --------- Signed-off-by: Siddharth Rayabharam <maitreya2954@gmail.com> Signed-off-by: Asim Mahmood <asim.seng@gmail.com> Signed-off-by: Asim M <asim.seng@gmail.com> Co-authored-by: Siddharth Rayabharam <maitreya2954@gmail.com> Co-authored-by: Craig Perkins <craig5008@gmail.com> (cherry picked from commit e3a6cca)
asimmahmood1
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
jainankitk and
linuxpi
as code owners
Signed-off-by: Asim Mahmood <asim.seng@gmail.com>
|
Convert this back to draft until further notice. Thanks. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.19 #17420 +/- ##
============================================
- Coverage 72.00% 71.97% -0.04%
Complexity 65963 65963
============================================
Files 5341 5341
Lines 307158 307179 +21
Branches 44824 44832 +8
============================================
- Hits 221184 221081 -103
- Misses 67498 67639 +141
+ Partials 18476 18459 -17 ☔ View full report in Codecov by Sentry. |
|
| To understand if it will break anything in 2.19.1. These changes are behind a new optional requset param for cardinality agg requests only. Without the new param, there is no change. There is a new response output, but its gated behind version. This in PR only nodes >= 2.19.1 will try to pass it. |
andrross
approved these changes
Feb 21, 2025
3 tasks
asimmahmood1
added a commit
to asimmahmood1/OpenSearch
that referenced
this pull request
Feb 21, 2025
* since 2.19 version has been merged: opensearch-project#17420 Signed-off-by: Asim Mahmood <asim.seng@gmail.com>
cwperks
pushed a commit
that referenced
this pull request
Feb 27, 2025
…kport to 2.x (#17419) * Introduce `execution_hint` for Cardinality aggregation (#17312) --------- Signed-off-by: Siddharth Rayabharam <maitreya2954@gmail.com> Signed-off-by: Asim Mahmood <asim.seng@gmail.com> Signed-off-by: Asim M <asim.seng@gmail.com> Co-authored-by: Siddharth Rayabharam <maitreya2954@gmail.com> Co-authored-by: Craig Perkins <craig5008@gmail.com> (cherry picked from commit e3a6cca) * Update changlog Signed-off-by: Asim Mahmood <asim.seng@gmail.com> * Update min version to 2_19_1 * since 2.19 version has been merged: #17420 Signed-off-by: Asim Mahmood <asim.seng@gmail.com> --------- Signed-off-by: Asim Mahmood <asim.seng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #17312 to 2.19
There's another PR for 2.x: #17419
Also need to backport the documentation opensearch-project/documentation-website#9224
Related Issues
Resolves #[16837]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.