Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Star Tree] [Search] Keyword & Numeric Terms Aggregation #17165

Merged
merged 11 commits into from
Mar 4, 2025

Conversation

sandeshkr419
Copy link
Contributor

@sandeshkr419 sandeshkr419 commented Jan 28, 2025

Description

  • Adds support for keyword & numeric terms aggregation.
  • Aggregations are supported with or without metric sub-aggregations
  • Aggregations are supported with previously supported queries for filtering (no change in support of adding up queries to requests)
  • Fix for timestamp field to be fetched from request/valueSource instead of hard-coded value (this change is already merged Fix date hardcoding in date aggregator #17239)

Related Issues

Resolves #16551

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Search:Aggregations labels Jan 28, 2025
@sandeshkr419 sandeshkr419 added backport 2.x Backport to 2.x branch v2.19.0 Issues and PRs related to version 2.19.0 and removed enhancement Enhancement or improvement to existing feature or request Search:Aggregations labels Jan 28, 2025
Copy link
Contributor

✅ Gradle check result for 33d4284: SUCCESS

@msfroh
Copy link
Collaborator

msfroh commented Mar 3, 2025

@sandeshkr419 -- can you please move the changelog entry from CHANGELOG.md to CHANGELOG-3.0.md?

Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Copy link
Contributor

github-actions bot commented Mar 3, 2025

❌ Gradle check result for 6e7dd3b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sandeshkr419 sandeshkr419 reopened this Mar 3, 2025
Copy link
Contributor

github-actions bot commented Mar 3, 2025

✅ Gradle check result for 6e7dd3b: SUCCESS

Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Copy link
Contributor

github-actions bot commented Mar 3, 2025

❕ Gradle check result for 88a56bf: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@msfroh msfroh merged commit 218f353 into opensearch-project:main Mar 4, 2025
30 checks passed
@sandeshkr419 sandeshkr419 deleted the k1 branch March 4, 2025 08:19
mayanksharma27 pushed a commit to mayanksharma27/OpenSearch that referenced this pull request Mar 5, 2025
…project#17165)

---------

Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Aggregations
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Star Tree] [Search] Bucket terms Aggregation with metric aggregation
3 participants