Updates version to fix BWC for SearchSourceBuilder #17098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junwei Dai <junweid@amazon.com>
junweid62
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
junweid62
changed the title
|
❌ Gradle check result for 1603f4e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
3 tasks
msfroh
approved these changes
Jan 23, 2025
|
❌ Gradle check result for 891ed56: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…ections Signed-off-by: Junwei Dai <junweid@amazon.com>
owaiskazi19
approved these changes
Jan 23, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17098 +/- ##
============================================
- Coverage 72.27% 72.26% -0.02%
+ Complexity 65397 65388 -9
============================================
Files 5306 5306
Lines 304213 304219 +6
Branches 44117 44117
============================================
- Hits 219881 219846 -35
- Misses 66333 66398 +65
+ Partials 17999 17975 -24 ☔ View full report in Codecov by Sentry. |
3 tasks
expani
pushed a commit
to expani/OpenSearch
that referenced
this pull request
Jan 27, 2025
…t#17098) * change version to 2.19 Signed-off-by: Junwei Dai <junweid@amazon.com> * bring back the constructor InternalSearchResponse and SearchResponseSections Signed-off-by: Junwei Dai <junweid@amazon.com> --------- Signed-off-by: Junwei Dai <junweid@amazon.com> Co-authored-by: Junwei Dai <junweid@amazon.com> Signed-off-by: expani <anijainc@amazon.com>
etolbakov
pushed a commit
to etolbakov/OpenSearch
that referenced
this pull request
Jan 29, 2025
…t#17098) * change version to 2.19 Signed-off-by: Junwei Dai <junweid@amazon.com> * bring back the constructor InternalSearchResponse and SearchResponseSections Signed-off-by: Junwei Dai <junweid@amazon.com> --------- Signed-off-by: Junwei Dai <junweid@amazon.com> Co-authored-by: Junwei Dai <junweid@amazon.com> Signed-off-by: Eugene Tolbakov <ev.tolbakov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Will merge this PR after #17097 got merged
To perform the BWC process:
1. Do this on main with onOrAfter(Version.V_3_0_0)). Get it merged.
2. You'll need a manual backport to 2.x, where you do onOrAfter(Version.V_2_19_0). Don't get it merged right away.
3. Before merging the backport to 2.x, open another PR on main to change it to onOrAfter(Version.V_2_19_0).
4. Merge the backport PR.
5. Merge the main version update PR.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.