Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Add RemoteStoreSettings class to handle remote store r… #12962

Merged
merged 4 commits into from
Apr 1, 2024

Conversation

sachinpkale
Copy link
Member

Backport 8ad0dc0 from #12838.

…elated settings (opensearch-project#12838)

* Add RemoteStoreSettings class to handle remote store related settings
---------
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Copy link
Contributor

github-actions bot commented Mar 28, 2024

Compatibility status:

Checks if related components are compatible with change d710640

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❌ Gradle check result for b5737fa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for f2930b0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sachinpkale
Copy link
Member Author

Needed to create manual backport PR due to conflicts in ClusterSettings class.

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Copy link
Contributor

✅ Gradle check result for 93c181a: SUCCESS

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.12%. Comparing base (0dd892c) to head (d710640).
Report is 100 commits behind head on 2.x.

Files Patch % Lines
...va/org/opensearch/indices/RemoteStoreSettings.java 88.23% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12962      +/-   ##
============================================
- Coverage     71.28%   71.12%   -0.16%     
- Complexity    60145    60389     +244     
============================================
  Files          4957     4987      +30     
  Lines        282799   284469    +1670     
  Branches      41409    41595     +186     
============================================
+ Hits         201591   202329     +738     
- Misses        64189    65070     +881     
- Partials      17019    17070      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Copy link
Contributor

github-actions bot commented Apr 1, 2024

❕ Gradle check result for d710640: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.gateway.RecoveryFromGatewayIT.testShardStoreFetchMultiNodeMultiIndexesUsingBatchAction
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@gbbafna gbbafna merged commit 270e81f into opensearch-project:2.x Apr 1, 2024
29 checks passed
@gbbafna gbbafna deleted the backport-12838-to-2.x branch April 1, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants