New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Broaden SecureSettingsFactory to include http transports #12907

Merged

peternied merged 4 commits into opensearch-project:main from reta:issue-12903

Mar 28, 2024

Merged

[FEATURE] Broaden SecureSettingsFactory to include http transports #12907

Address code review comments, added more tests

Codecov / codecov/patch succeeded Mar 28, 2024 in 0s

90.00% of diff hit (target 71.42%)

View this Pull Request on Codecov

90.00% of diff hit (target 71.42%)

Annotations

Check warning on line 133 in modules/transport-netty4/src/main/java/org/opensearch/http/netty4/ssl/SecureNetty4HttpServerTransport.java

codecov / codecov/patch

modules/transport-netty4/src/main/java/org/opensearch/http/netty4/ssl/SecureNetty4HttpServerTransport.java#L133

Added line #L133 was not covered by tests

Check warning on line 221 in modules/transport-netty4/src/main/java/org/opensearch/http/netty4/ssl/SecureNetty4HttpServerTransport.java

codecov / codecov/patch

modules/transport-netty4/src/main/java/org/opensearch/http/netty4/ssl/SecureNetty4HttpServerTransport.java#L221

Added line #L221 was not covered by tests

Check warning on line 36 in server/src/main/java/org/opensearch/plugins/SecureTransportSettingsProvider.java

codecov / codecov/patch

server/src/main/java/org/opensearch/plugins/SecureTransportSettingsProvider.java#L36

Added line #L36 was not covered by tests

View more details on Codecov