-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete compose version specifier #9404
base: main
Are you sure you want to change the base?
Conversation
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Signed-off-by: Simon Weiß <weiss.simon@outlook.com>
b0b909c
to
3599362
Compare
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "Remove obsolete docker compose version specifier". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9404 +/- ##
==========================================
- Coverage 61.73% 61.71% -0.02%
==========================================
Files 3817 3817
Lines 91860 91860
Branches 14551 14551
==========================================
- Hits 56707 56695 -12
- Misses 31496 31508 +12
Partials 3657 3657
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the note that this will need docker-compose V2
Hey @Hailong-am, personally I wouldn't do that. Compose V1 has stopped receiving updates in July 2023. I changed this across other libraries in the OpenSearch Org without a notice. |
Description
Version specifier for docker compose is obsolete. See: https://docs.docker.com/reference/compose-file/version-and-name/#version-top-level-element-obsolete
See this PR to collect changes across opensearch-project repos: opensearch-project/documentation-website#8606
Changelog