Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete compose version specifier #9404

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SimonCW
Copy link

@SimonCW SimonCW commented Feb 17, 2025

Description

Version specifier for docker compose is obsolete. See: https://docs.docker.com/reference/compose-file/version-and-name/#version-top-level-element-obsolete

See this PR to collect changes across opensearch-project repos: opensearch-project/documentation-website#8606

Changelog

  • skip

Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Signed-off-by: Simon Weiß <weiss.simon@outlook.com>
@SimonCW SimonCW force-pushed the fix/compose-version branch from b0b909c to 3599362 Compare February 17, 2025 21:53
Copy link
Contributor

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "Remove obsolete docker compose version specifier". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.71%. Comparing base (126c144) to head (ce2fa11).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9404      +/-   ##
==========================================
- Coverage   61.73%   61.71%   -0.02%     
==========================================
  Files        3817     3817              
  Lines       91860    91860              
  Branches    14551    14551              
==========================================
- Hits        56707    56695      -12     
- Misses      31496    31508      +12     
  Partials     3657     3657              
Flag Coverage Δ
Linux_1 29.00% <ø> (ø)
Linux_2 56.46% <ø> (ø)
Linux_3 39.19% <ø> (?)
Linux_4 28.90% <ø> (ø)
Windows_1 29.01% <ø> (-0.02%) ⬇️
Windows_2 56.41% <ø> (ø)
Windows_3 39.20% <ø> (ø)
Windows_4 28.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Feb 18, 2025
Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the note that this will need docker-compose V2

@SimonCW
Copy link
Author

SimonCW commented Feb 20, 2025

Hey @Hailong-am, personally I wouldn't do that. Compose V1 has stopped receiving updates in July 2023. I changed this across other libraries in the OpenSearch Org without a notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants