-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NMS-13163: enable Docker Content Trust #21
Draft
swachter
wants to merge
41
commits into
master
Choose a base branch
from
jira/NMS-13163
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+158
−100
Draft
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
b626212
NMS-13163: enable Docker Content Trust
swachter f4bb1d0
fix decoding statement
swachter ce94f8b
fix option name
swachter 0c57e15
switch to opennmsdcttest repo; set build context for maven-jdk* jobs
swachter 595e273
contexts for all!
swachter 85513cf
include only some jobs
swachter fc81a36
change base of openjdk-11 image
swachter 3fd7998
disable change detection
swachter 09e4134
adapt centos image version
swachter fe7c1a8
use the same build numbers everywhere
swachter dd08d32
tag centos image for use as base image
swachter 090ee82
push always
swachter 242edf3
rely on common tagging logic; try other java version detail
swachter 344af99
try another openjdk version
swachter 853782d
adjust base image version of maven-jdk11 image
swachter 65befe9
use CONTAINER_REGISTRY_REPO to address base images
swachter e9ecc3c
replace CONTAINER_REGISTRY_REPO by constants (because it is yet defined)
swachter fcc8a47
replace try with other root key
swachter f4a5f4a
use swachter repo
swachter b306c99
set registry/repo in common build.sh
swachter 7a3ae45
enable dct for pushing
swachter 49960eb
use BASH_EVN
swachter 0e7b727
use BASH_EVN
swachter 81eb479
use BASH_EVN
swachter 8119204
test BASH_ENV
swachter c9b805d
test BASH_ENV
swachter d780d12
test BASH_ENV
swachter b6c90bc
test BASH_ENV
swachter c3da1b7
test BASH_ENV
swachter f53daa3
test BASH_ENV
swachter 2fb78cc
test BASH_ENV
swachter 35549b3
test BASH_ENV
swachter 9df90f0
test BASH_ENV
swachter 6efd3eb
test BASH_ENV
swachter 516ead5
disable DCT for docker build
swachter 310a057
disable DCT for docker build
swachter 4895247
disable DCT for docker build
swachter bde135f
check tagging
swachter 2952806
opennmsdcttest repo
swachter 46e20d8
fix build.sh
swachter 854447d
build openjdk and maven images
swachter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CONTAINER_REGISTRY (docker.io) and CONTAINER_REGISTRY_REPO/ORGANISATION (opennmsdcttest) are now given by CircleCI config instead of the config in the repository. What I see right now are three options:
Just double checking here if this is the best place to define the target publishing images with just in mind we might want to switch to a different registry structure. It's not super critical, read this here more like an informal comment not as a change request :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the registry / organization should be settable from the outside then we should rethink how we handle the "no build args in
FROM
" limitation of docker builds with content trust. Some base images have to be addressed by the registry / organization.