Enhancement: Improved UPF routing and NAT handling #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced static aether-ue-nat.service with dynamic aether-ue-nat.service.j2 - Updated install.yaml to use Jinja2 templating for NAT service - Improved 20-aether-core.network to dynamically add routes for additional UPFs - Modified add UPF module to check for existing routes before adding - Ensured consistent route management between core network and UPF installation Signed-off-by: hxngillani <h.shabir@studenti.unipi.it>
hxngillani
force-pushed
the
upf-routing-improvements
branch
from
081a98a to
fd8760a
Compare
|
Hi @hxngillani, thanks for your contribution Hi @llpeterson, @mbilal92, can you please review this PR? Thanks! |
gab-arrobo
reviewed
Feb 27, 2025
Comment on lines
13
to
20
| {% if '1' in core.upf.additional_upfs %} \ | ||
| sudo iptables -t nat -C POSTROUTING -s {{ core.upf.additional_upfs['1'].ue_ip_pool }} -o {{ core.data_iface }} -j MASQUERADE || \ | ||
| sudo iptables -t nat -A POSTROUTING -s {{ core.upf.additional_upfs['1'].ue_ip_pool }} -o {{ core.data_iface }} -j MASQUERADE; \ | ||
| {% endif %} \ | ||
| {% if '2' in core.upf.additional_upfs %} \ | ||
| sudo iptables -t nat -C POSTROUTING -s {{ core.upf.additional_upfs['2'].ue_ip_pool }} -o {{ core.data_iface }} -j MASQUERADE || \ | ||
| sudo iptables -t nat -A POSTROUTING -s {{ core.upf.additional_upfs['2'].ue_ip_pool }} -o {{ core.data_iface }} -j MASQUERADE; \ | ||
| {% endif %} \ |
There was a problem hiding this comment.
What happens if someone wants to deploy more than 2 additional UPFs? Would it be better to replace these if statements by a for loop?
There was a problem hiding this comment.
Thank you for review great idea let me do that and test if it works will then amend in PR
There was a problem hiding this comment.
i have updated and tested it is working now for multiple UPFs use case.
Signed-off-by: hxngillani <h.shabir@studenti.unipi.it>
hxngillani
force-pushed
the
upf-routing-improvements
branch
from
fd8760a to
cea71ab
Compare
gab-arrobo
reviewed
Mar 3, 2025
Comment on lines
+62
to
63
|
|
||
| # ignore_errors: yes |
There was a problem hiding this comment.
If ignore_errors is not used, I think it is better to just remove it
Suggested change
| # ignore_errors: yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Dynamic UPF Routing and NAT Handling
Changes Made:
aether-ue-nat.servicewithaether-ue-nat.service.j2for dynamic NAT configuration..install.yamlto generate the NAT service dynamically based on UPF configuration.20-aether-core.networkto dynamically add routes for additional UPFs.Why This Change?
aether-ue-nat.servicewas static, meaning new UPFs required manual modifications.RTNETLINK answers: File existswhen adding new UPFs.Testing & Validation:
Notes for Reviewers: