Proposal data caching #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Aug 13, 2021
* WIP cache proposal data * WIP use queryClient * WIP refactor with useQuery hooks * apply caching strategy to governance proposals * apply proposal data caching to individual proposal details * Revert "apply proposal data caching to individual proposal details" This reverts commit 3261578. * Revert "Revert "apply proposal data caching to individual proposal details"" This reverts commit faa91be. * WIP refetch for proposal actions updates * fix proposal action transitions * format comment * fix proposal action transitions * format comments * WIP update tests * clean up hook after caching update * update useProposals unit tests * update useGovernanceProposals unit tests * update useDaoProposals unit test * update comment * WIP fix last of failing tests * remove react query dev tools * update queryClient import in setupTests * update testing clear cache * fixes outdated env vars being set * fixes useProposalsVotes tests and makes slight improvements to code * improve use of react queries Co-authored-by: Jeremiah Naylor-Trein <jeremiahtrein@gmail.com> f01cd96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements caching strategy for proposal data using React Query as part of #423. (The issue description covers more than what is addressed by this PR so it should not be closed with just these updates.)
🥳 Adds
react-querylibrary to implement caching strategy for fetched proposal data (see Improve state management for remote data fetching (i.e. caching, re-renders, etc.) #423 for more info)✨ Updates
react-query