-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup wizard: Add primary IP config #2565
Conversation
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
#1946 Bundle Size — 10.59MiB (+0.07%).Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch mherwege:primary_ip_config Project dashboard |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks good to me, however there are a few points I will take care of:
- Seems like something went wrong when rebasing my changes from Setup wizard: Refactor add-on selection & Add descriptions for JS Scripting & Astro #2556 (I will clean-up the re-added code).
- Use parameter-options for primary network selection: This makes only one of the network interfaces selectable and improves consistency with the actual network settings.
- Refactor API call logic to use one big Promise.all (makes the code more readable and loading more predictable).
- Handle locale change for the add-on selection inside the addon-setup-wizard component (related to the code clean-up above).
- Fix an issue, where suggestions were not applied when an add-on tab was opened before the suggestions were loaded (I have used some event handling to fix that issue).
I just tested snapshot 4077 on a Windows PC. I do not see any step "Setup Primary Network" during the Setup wizard. |
Don't know if this is important but I passed/ignored the previous step (localisation). |
Skipping location doesn’t matter. |
Ok. On Windows, it looks like the WiFi interface does not linked to an IP address when the Ethernet interface is up, even if WiFi is enabled. |
Add-on finders scan the network for devices supported by OH add-ons to suggest suitable add-ons. These are presented in the setup-wizard (and add-ons store).
To limit network traffic, especially for ip broadcast and multicast, finders could limit the traffic to one subnet. This is especially relevant if the setup would be on servers with many network interfaces or when using Docker. The broadcast address can be controlled through network settings. However, these network settings so far are only accessible through the UI after initial setup.
If the broadcast address or primary IP address is not set, one will be used from the list randomly.
This PR adds one step in the setup process, setting up a primary IP address. This will automatically also default the broadcast address to the broadcast address of the primary IP subnet. Querying the suggestion finder service for add-on suggestions is delayed until after this step, and some delay is built into the process to allow suggestions finders to scan the network.
See discussion in openhab/openhab-core#4036