Watch network overhaul #857
Conversation
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
|
Just FYi, i am still working on this, just getting SSL certificate prompting working , almost done. |
|
Great. I was just addressing the painful github actions issues. |
|
Thank you for doing that, and your right, it is painful ! |
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
|
@timbms thanks for those fastlane fixes as this just passed ! If there are no objections this is ready to merge in, i tested quite a bit with invalid certs, myopenhab, etc.. etc.. i think its ready to go. |
|
LGTM. |
|
Maybe we can migrate to async/await with URL Session in a next step. And then get rid of these complex completion handlers |
|
Yes, sounds good, I was reluctant to go further yet with network refactoring as i'm not sure what we want to do with #799 ? We will still need a basic http client in addition to you PR for non openAPI endpints , if we could get #799 merged , i was hoping we could refactor my little http client and the generated swift client to use a shared URLSession that would then use a common authentication, SSL handling, and client certificates handler/delegate. I would also then convert any non async code to async and finally get rid of alamo fire completely . |
This overhauls the networking for the watch, removing alamo fire. I just could not get alamo working reliably on the watch, probably something i was doing wrong. In any case, this is now using the shared HTTP class with standard http swift networking.