-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Airflow
, Application
, Channel
, and Mode
Semantic Properties
#4616
base: main
Are you sure you want to change the base?
Conversation
@andrewfg fyi |
Please separate version upgrade from semantic tags. Not sure about Mode, might be fine but it seems not as specific as channel and application. Also wondering if adding these tags would need additional work in mainUI, @ghys ? |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
f278db3
to
09d0bcf
Compare
I've split them up into separate commits |
All commits are pushed? As I still see the version change and the tag together |
@jimtng - can you add |
Application
, Channel
, and Mode
PropertiesAirflow
, Application
, Channel
, and Mode
Properties
Yes they are split up properly. There are 4 commits with airflow in a separate commit to the other 3 tags. Should I split each tag into a separate commit? |
Title updated |
Airflow
, Application
, Channel
, and Mode
PropertiesAirflow
, Application
, Channel
, and Mode
Semantic Properties
f073d7c
to
7bc8f16
Compare
I can't definitively answer but given that custom tags are supported everywhere and I believe MainUI uses the REST API endpoint to get the lags there shouldn't be any wider changes required. But I wonder if it makes sense to have a more deliberate discussion on what tags belong or not at a higher level and come up with a PR to address them all instead adding two here and four there in separate PRs without really designing the tags. For example, Battery, online status, pressure, VoC, Radon, air quality, are missing properties. There are a bunch of car related points and properties missing and car is missing from Equipment. On-the-other-hand, do we really need seven different types of Doors at the Equipment level and does it make sense to have smokealarm at all given the alarm/smoke point/property combo? I worry that if we just add stuff here and there the lists will always remain inconsistent and eventually grow beyond usability. Note, I'm all for adding the four properties listed here. Even mode makkes sense: HVAC Equipment has a Control/Mode Point to set the heating/cooling/auto status. |
See #4615 in which we are seeking to apply an XSD schema restriction so that addon developers will be able to offer one “point” tag and one “property” tag; this offer would be a hint that users could choose to accept or override.
@rkoshak may I therefore make a call to action on you to open a PR for those; or at least open an Issue..
PS see also #4617 .. |
Please create a separate PR for that to have it merged quickly even if your proposal of new properties is finally not validated. |
|
Should be rebased now that #4621 is merged. |
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
7bc8f16
to
669feae
Compare
rebased |
Bit late, but I meant PR’s not commits. |
Add new properties to support TV and Airconditioner points
Also upgrade groovy version to work with Java21
Adjust copyright header