Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide I18N properties for Unit Settings #3941

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Dec 20, 2023

Seems missing from #3503.

Generated by:

mvn i18n:generate-default-translations

Then manually moved to new file units.properties where I manually added the last line:

service.system.units.label = Unit Settings

I don't know if this is the correct process or if there is a better one.

To make sure the manually added label is correct, I built and tested it with a Danish string provided:

image

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur requested a review from a team as a code owner December 20, 2023 10:58
@J-N-K J-N-K added the i18n/l10n Internationalization/Localization label Dec 20, 2023
@J-N-K J-N-K merged commit e8641ef into openhab:main Dec 20, 2023
@J-N-K J-N-K added this to the 4.1 milestone Dec 20, 2023
@jlaur jlaur deleted the unit-settings-i18n branch December 20, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n/l10n Internationalization/Localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants