[opensprinkler] Fix excessive WARN in logs due to wifi dropouts, and current displays as 0 #16080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Skinah
changed the title
jlaur
requested changes
Dec 19, 2023
...r/src/main/java/org/openhab/binding/opensprinkler/internal/api/OpenSprinklerHttpApiV100.java
Show resolved
Hide resolved
bundles/org.openhab.binding.opensprinkler/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
jlaur
changed the title
…H-INF/thing/thing-types.xml Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Matthew Skinner <matt@pcmus.com>
J-N-K
approved these changes
Dec 20, 2023
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…current displays as 0 (openhab#16080) * Fix 300mA current draw will display as 0 due to rounding. * Remove WARN logs when retries have not yet expired. Signed-off-by: Matthew Skinner <matt@pcmus.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
…current displays as 0 (openhab#16080) * Fix 300mA current draw will display as 0 due to rounding. * Remove WARN logs when retries have not yet expired. Signed-off-by: Matthew Skinner <matt@pcmus.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The channel will display "0" when the current draw is 300mA, so users will think this is a bug. Changing the default state description allows it to be displayed as '0.3 A'
Also the WARN that is changed to DEBUG is very annoying in the logs as the sprinkler controller is often located outside a long way from the wifi and getting multiple WARNS when it has not yet failed all the allowed retries is IMHO not inline with logging guidelines.
Signed-off-by: Matthew Skinner matt@pcmus.com