Update net framework #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From this commit forward, the minimum Visual Studio Version is 10.0.30320.27.
edalex-ian
approved these changes
Apr 12, 2021
There was a problem hiding this comment.
Looks okay. Seems the only real code change was some typecasting - everything else was updated auto-generated files.
But a few things of note that hopefully you've considered:
- A lot the changes are simple whitespace. I think it's just the format has changed (I think between tabs and spaces); and
- There is now some new embedded paths which are specific to your machine, however I note these used to be specific to "Jim's" machine so that's probably not any worse.
| EMU requires .NET framework 3.5 or higher. | ||
| To make modifications to and test EMU Visual C# 2008 or higher and WiX Toolset for packaging (wixtoolset.org) is required on the workstation. | ||
| EMU requires .NET framework 4.8 or higher. | ||
| To make modifications to and test EMU, Visual Studio 10.0.30320.27 or higher and WiX Toolset v3.11.2 for packaging (https://github.com/wixtoolset/wix3/releases/tag/wix3112rtm) is required on the workstation. |
There was a problem hiding this comment.
Suggested change
| To make modifications to and test EMU, Visual Studio 10.0.30320.27 or higher and WiX Toolset v3.11.2 for packaging (https://github.com/wixtoolset/wix3/releases/tag/wix3112rtm) is required on the workstation. | |
| To undertake development of EMU your workstation requires: | |
| - Visual Studio 10.0.30320.27 or higher; and | |
| - [WiX Toolset v3.11.2](https://github.com/wixtoolset/wix3/releases/tag/wix3112rtm) - for packaging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to support issue regarding .NET support of TLS 1.2. This PR migrates the project to work with modern Visual Studio and .NET framework 4.8 and the latest version of WiX.