Analytics plugins #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-chekyrta
requested changes
Mar 3, 2025
| @@ -0,0 +1,15 @@ | |||
| // | |||
| // File.swift | |||
There was a problem hiding this comment.
Please change the filename to DeepLinkManagerProtocol.swift
| @@ -0,0 +1,27 @@ | |||
| // | |||
| // File.swift | |||
There was a problem hiding this comment.
Please change the filename to DeepLinkManagerProtocolMock.swift
|
|
||
| import Foundation | ||
|
|
||
| public class DeepLinkManagerProtocolMock: DeepLinkManagerProtocol { |
There was a problem hiding this comment.
Is it for tests or users?
Can we remove public to hide it from plugin users if it's for tests?
| // | ||
|
|
||
| import Foundation | ||
| import UIKit |
There was a problem hiding this comment.
Do we need this import for protocol?
volodymyr-chekyrta
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added needed protocols for analytics plugins implementation:
moved PushNotificationsProvider protocol to Foundation
moved PushNotificationsListener protocol to Foundation
moved DeepLinkManagerProtocol protocol to Foundation
added extension for Error