-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0078] Authorization request dialog #431
feat: [FC-0078] Authorization request dialog #431
Conversation
Thanks for the pull request, @PavloNetrebchuk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
...overy/src/main/java/org/openedx/discovery/presentation/detail/AuthorizationFragmentDialog.kt
Outdated
Show resolved
Hide resolved
...overy/src/main/java/org/openedx/discovery/presentation/detail/AuthorizationFragmentDialog.kt
Outdated
Show resolved
Hide resolved
...overy/src/main/java/org/openedx/discovery/presentation/detail/AuthorizationFragmentDialog.kt
Outdated
Show resolved
Hide resolved
...overy/src/main/java/org/openedx/discovery/presentation/detail/AuthorizationFragmentDialog.kt
Outdated
Show resolved
Hide resolved
ad4dfaf
to
1a2ca80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have some minor questions
...overy/src/main/java/org/openedx/discovery/presentation/detail/AuthorizationFragmentDialog.kt
Outdated
Show resolved
Hide resolved
val courseId = requireArguments().getString(ARG_COURSE_ID) ?: "" | ||
AuthorizationDialogView( | ||
onRegisterButtonClick = { | ||
dismiss() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe dismissing should happens after action, not before
...overy/src/main/java/org/openedx/discovery/presentation/detail/AuthorizationFragmentDialog.kt
Outdated
Show resolved
Hide resolved
@k1rill Thank you for your feedback! I’ve already made the changes. Please review them. |
1a2ca80
to
4bfff05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In offline mode, trigger the authorization dialog instead of navigating to the logistration screen.