-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add single sing on by saml #420
base: develop
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @RawanMatar89! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
# Conflicts: # app/src/main/java/org/openedx/app/AppRouter.kt # app/src/main/java/org/openedx/app/di/ScreenModule.kt # auth/src/main/java/org/openedx/auth/presentation/signin/SignInFragment.kt # auth/src/main/java/org/openedx/auth/presentation/signin/SignInViewModel.kt # auth/src/main/java/org/openedx/auth/presentation/signin/compose/SignInView.kt # build.gradle # core/src/main/java/org/openedx/core/config/Config.kt # core/src/main/res/values/strings.xml # default_config/prod/config.yaml # default_config/stage/config.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
@RawanMatar89 it looks like there are some failing tests and checks, can you have a look. We can review this when the checks are passing. I also want to make sure we ensure this work meshes will with this: @xitij2000 can you chime in here? |
I am currently unable to test the code or have a deeper look; however, I do see some overlap. #371 adds a web-browser based flow that will initiate an OAuth flow with the LMS, delegating the actual login mechanism to whatever IdPs are set up at the LMS including any SAML-based ones. So from what I understand, what this PR is doing is already possible using the existing code. |
Describtion:
as in iOS, we added a new button in sign in view named "Sign in with SSO" to be use for opening single sign on web view
Screenshots: