Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add single sing on by saml #420

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

RawanMatar89
Copy link

Describtion:

as in iOS, we added a new button in sign in view named "Sign in with SSO" to be use for opening single sign on web view

Screenshots:

Before After (both) After (SSO only)
b1 a1 a2

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 10, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 10, 2025

Thanks for the pull request, @RawanMatar89!

This repository is currently maintained by @openedx/openedx-mobile-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

# Conflicts:
#	app/src/main/java/org/openedx/app/AppRouter.kt
#	app/src/main/java/org/openedx/app/di/ScreenModule.kt
#	auth/src/main/java/org/openedx/auth/presentation/signin/SignInFragment.kt
#	auth/src/main/java/org/openedx/auth/presentation/signin/SignInViewModel.kt
#	auth/src/main/java/org/openedx/auth/presentation/signin/compose/SignInView.kt
#	build.gradle
#	core/src/main/java/org/openedx/core/config/Config.kt
#	core/src/main/res/values/strings.xml
#	default_config/prod/config.yaml
#	default_config/stage/config.yaml
@RawanMatar89 RawanMatar89 marked this pull request as ready for review February 10, 2025 08:42
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Feb 11, 2025
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@e0d
Copy link

e0d commented Feb 14, 2025

@RawanMatar89 it looks like there are some failing tests and checks, can you have a look. We can review this when the checks are passing.

I also want to make sure we ensure this work meshes will with this:

#371

@xitij2000 can you chime in here?

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Feb 14, 2025
@xitij2000
Copy link
Contributor

@RawanMatar89 it looks like there are some failing tests and checks, can you have a look. We can review this when the checks are passing.

I also want to make sure we ensure this work meshes will with this:

#371

@xitij2000 can you chime in here?

I am currently unable to test the code or have a deeper look; however, I do see some overlap. #371 adds a web-browser based flow that will initiate an OAuth flow with the LMS, delegating the actual login mechanism to whatever IdPs are set up at the LMS including any SAML-based ones. So from what I understand, what this PR is doing is already possible using the existing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

5 participants