fix: bug when the name of subcategory is empty

[dixidroid]

fixed a bug when the name of subcategory was empty in Discussions

[HamzaIsrar12]

I've asked Moiz to confirm the default string for us. Meanwhile, I believe it would be wise to minimize the usage of topic.name to zero, as it could potentially cause issues in other areas as well.

Regarding an alternative approach, using something like this codesnippet to fetch the topic title from one common place seems like a good idea. Thoughts?

[dixidroid]

@HamzaIsrar12 I changed where the topic name located. Check it please. Waiting for Moiz's confirmation...

[volodymyr-chekyrta]

Not sure if the UI layer code can be stored in the domain model.
Is there any possibility to move it to the UI layer?

[HamzaIsrar12]

Continuing your thought process, @volodymyr-chekyrta, perhaps we can update it at the repository level.

    suspend fun getCourseTopics(courseId: String): List<Topic> {
        val topicsData = api.getCourseTopics(courseId).mapToDomain()

        // Fetch default name
        val defaultTopicName = resourceManager.getString(R.string.discussion_unnamed_subcategory)

        currentCourseId = courseId
        topics.clear()
        topics.addAll(topicsData.nonCoursewareTopics)
        topicsData.coursewareTopics.forEach {
            topics.add(it)
            if (it.children.isNotEmpty()) {
                topics.addAll(it.children)
            }
        }
        
        // New Code
        topics.forEachIndexed { index, topic ->
            if (topic.name.isBlank()) {
                topics[index] = topic.copy(name = defaultTopicName)
            }
        }
        // End
        
        return topics.toList()
    }

Thoughts?

[dixidroid]

done

[HamzaIsrar12]

@dixidroid Moiz has approved the usage of "Unnamed subcategory". 👍🏻