feat: Login through username in the new app #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add username support for the authentication fixes: LEARNER-9782
omerhabib26
suggested changes
Jan 12, 2024
auth/src/main/java/org/openedx/auth/presentation/restore/RestorePasswordFragment.kt
Outdated
Show resolved
Hide resolved
auth/src/test/java/org/openedx/auth/presentation/signin/SignInViewModelTest.kt
Outdated
Show resolved
Hide resolved
| Pattern.compile("^[A-Z0-9._%+-]+@[A-Z0-9.-]+\\.[A-Z]{2,6}$", Pattern.CASE_INSENSITIVE) | ||
| val matcher = validEmailAddressRegex.matcher(email) | ||
| return matcher.find() | ||
| fun isEmailOrUserNameValid(email: String): Boolean { |
There was a problem hiding this comment.
we are still only verifying the email address, do we need to verify the username?
There was a problem hiding this comment.
we only need to check that user name shouldn't be empty. iOS did the same.
There was a problem hiding this comment.
it would be great if you could just check space in the field.
There was a problem hiding this comment.
already replaced with isBlank, so no need to check white spaces. Also can trim the white space in case of non-blank. thoughts?
k1rill
previously approved these changes
Jan 18, 2024
farhan-arshad-dev
dismissed stale reviews from omerhabib26 and k1rill
via
0b709c4
omerhabib26
pushed a commit
to omerhabib26/openedx-app-android
that referenced
this pull request
Jan 22, 2024
- Add username support for the authentication fixes: LEARNER-9782
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
usernamesupport for the authentication.