refactor: Updated event names and bi values

Fixes: LEARNER-9941
openedx · Apr 24, 2024 · 8022b51 · 8022b51
1 parent 8d070d0
commit 8022b51
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/core/src/main/java/org/openedx/core/presentation/CoreAnalytics.kt b/core/src/main/java/org/openedx/core/presentation/CoreAnalytics.kt
@@ -39,7 +39,7 @@ enum class CoreAnalyticsKey(val key: String) {
     NAME("name"),
     CATEGORY("category"),
     DISCOVERY("discovery"),
-    VIDEOS("video"),
+    VIDEOS("videos"),
     PROFILE("profile"),
     URL("url"),
     ACTION("action"),

diff --git a/core/src/main/java/org/openedx/core/presentation/dialog/appreview/AppReviewAnalytics.kt b/core/src/main/java/org/openedx/core/presentation/dialog/appreview/AppReviewAnalytics.kt
@@ -19,7 +19,7 @@ enum class AppReviewAnalyticsKey(val key: String) {
     NAME("name"),
     CATEGORY("category"),
     RATING("rating"),
-    APP_REVIEW("app_reviews"),
+    APP_REVIEWS("app_reviews"),
     ACTION("action"),
     DISMISSED("dismissed"),
     NOT_NOW("not_now"),

diff --git a/...c/main/java/org/openedx/core/presentation/dialog/appreview/BaseAppReviewDialogFragment.kt b/...c/main/java/org/openedx/core/presentation/dialog/appreview/BaseAppReviewDialogFragment.kt
@@ -26,7 +26,7 @@ open class BaseAppReviewDialogFragment : DialogFragment() {
             event = AppReviewAnalyticsEvent.RATING_DIALOG.eventName,
             params = buildMap {
                 put(AppReviewAnalyticsKey.NAME.key, AppReviewAnalyticsEvent.RATING_DIALOG.biValue)
-                put(AppReviewAnalyticsKey.CATEGORY.key, AppReviewAnalyticsKey.APP_REVIEW.key)
+                put(AppReviewAnalyticsKey.CATEGORY.key, AppReviewAnalyticsKey.APP_REVIEWS.key)
             }
         )
     }
@@ -65,7 +65,7 @@ open class BaseAppReviewDialogFragment : DialogFragment() {
                     AppReviewAnalyticsKey.NAME.key,
                     AppReviewAnalyticsEvent.RATING_DIALOG_ACTION.biValue
                 )
-                put(AppReviewAnalyticsKey.CATEGORY.key, AppReviewAnalyticsKey.APP_REVIEW.key)
+                put(AppReviewAnalyticsKey.CATEGORY.key, AppReviewAnalyticsKey.APP_REVIEWS.key)
                 put(AppReviewAnalyticsKey.ACTION.key, action)
                 rating.nonZero()?.let { put(AppReviewAnalyticsKey.RATING.key, it) }
             }

diff --git a/discovery/src/main/java/org/openedx/discovery/presentation/DiscoveryAnalytics.kt b/discovery/src/main/java/org/openedx/discovery/presentation/DiscoveryAnalytics.kt
@@ -10,7 +10,7 @@ interface DiscoveryAnalytics {
 enum class DiscoveryAnalyticsEvent(val eventName: String, val biValue: String) {
     COURSE_INFO(
         "Discovery:Course Info",
-        "edx.bi.app.course.info"
+        "edx.bi.app.discovery.course_info"
     ),
     PROGRAM_INFO(
         "Discovery:Program Info",