fix: address PR comments

openedx · Feb 12, 2024 · 6189314 · 6189314
1 parent 046fec0
commit 6189314
Show file tree

Hide file tree

Showing 6 changed files with 60 additions and 7 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -106,6 +106,13 @@ dependencies {
 
     implementation 'androidx.core:core-splashscreen:1.0.1'
 
+    // Segment Library
+    implementation "com.segment.analytics.kotlin:android:1.14.2"
+    // Segment's Firebase integration
+    implementation 'com.segment.analytics.kotlin.destinations:firebase:1.5.2'
+    // Braze SDK Integration
+    implementation "com.braze:braze-segment-kotlin:1.4.2"
+
     androidTestImplementation 'androidx.test.ext:junit:1.1.5'
     androidTestImplementation 'androidx.test.espresso:espresso-core:3.5.1'
     androidTestImplementation "androidx.compose.ui:ui-test-junit4:$compose_version"

diff --git a/core/build.gradle b/core/build.gradle
@@ -152,13 +152,6 @@ dependencies {
     //Play In-App Review
     api "com.google.android.play:review-ktx:$in_app_review"
 
-    // Segment Library
-    api "com.segment.analytics.kotlin:android:1.14.2"
-    // Segment's Firebase integration
-    api 'com.segment.analytics.kotlin.destinations:firebase:1.5.2'
-    // Braze SDK Integration
-    api "com.braze:braze-segment-kotlin:1.4.2"
-
     testImplementation 'junit:junit:4.13.2'
     androidTestImplementation 'androidx.test.ext:junit:1.1.5'
     androidTestImplementation 'androidx.test.espresso:espresso-core:3.5.1'

diff --git a/core/src/main/java/org/openedx/core/config/AnalyticsSource.kt b/core/src/main/java/org/openedx/core/config/AnalyticsSource.kt
@@ -5,5 +5,7 @@ import com.google.gson.annotations.SerializedName
 enum class AnalyticsSource {
     @SerializedName("segment")
     SEGMENT,
+
+    @SerializedName("none")
     NONE,
 }
diff --git a/default_config/dev/config.yaml b/default_config/dev/config.yaml
@@ -28,6 +28,23 @@ PROGRAM:
     PROGRAM_URL: ''
     PROGRAM_DETAIL_URL_TEMPLATE: ''
 
+FIREBASE:
+  ENABLED: false
+  ANALYTICS_SOURCE: '' # segment | none
+  CLOUD_MESSAGING_ENABLED: false
+  PROJECT_ID: ""
+  APPLICATION_ID: ""
+  API_KEY: ""
+  GCM_SENDER_ID: ""
+
+SEGMENT_IO:
+  ENABLED: false
+  SEGMENT_IO_WRITE_KEY: ''
+
+BRAZE:
+  ENABLED: false
+  PUSH_NOTIFICATIONS_ENABLED: false
+
 GOOGLE:
   ENABLED: false
   CLIENT_ID: ''

diff --git a/default_config/prod/config.yaml b/default_config/prod/config.yaml
@@ -28,6 +28,23 @@ PROGRAM:
     PROGRAM_URL: ''
     PROGRAM_DETAIL_URL_TEMPLATE: ''
 
+FIREBASE:
+  ENABLED: false
+  ANALYTICS_SOURCE: '' # segment | none
+  CLOUD_MESSAGING_ENABLED: false
+  PROJECT_ID: ""
+  APPLICATION_ID: ""
+  API_KEY: ""
+  GCM_SENDER_ID: ""
+
+SEGMENT_IO:
+  ENABLED: false
+  SEGMENT_IO_WRITE_KEY: ''
+
+BRAZE:
+  ENABLED: false
+  PUSH_NOTIFICATIONS_ENABLED: false
+
 GOOGLE:
   ENABLED: false
   CLIENT_ID: ''

diff --git a/default_config/stage/config.yaml b/default_config/stage/config.yaml
@@ -28,6 +28,23 @@ PROGRAM:
     PROGRAM_URL: ''
     PROGRAM_DETAIL_URL_TEMPLATE: ''
 
+FIREBASE:
+  ENABLED: false
+  ANALYTICS_SOURCE: '' # segment | none
+  CLOUD_MESSAGING_ENABLED: false
+  PROJECT_ID: ""
+  APPLICATION_ID: ""
+  API_KEY: ""
+  GCM_SENDER_ID: ""
+
+SEGMENT_IO:
+  ENABLED: false
+  SEGMENT_IO_WRITE_KEY: ''
+
+BRAZE:
+  ENABLED: false
+  PUSH_NOTIFICATIONS_ENABLED: false
+
 GOOGLE:
   ENABLED: false
   CLIENT_ID: ''