feat: show video learning type to learners with active subscription

openedx · Aug 6, 2024 · 17fcbfc · 17fcbfc
1 parent 7581607
commit 17fcbfc
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 26 deletions.
diff --git a/packages/catalog-search/src/LearningTypeRadioFacet.jsx b/packages/catalog-search/src/LearningTypeRadioFacet.jsx
@@ -13,7 +13,7 @@ import {
 } from './data/constants';
 
 const LearningTypeRadioFacet = ({ enablePathways }) => {
-  const { refinements, dispatch } = useContext(SearchContext);
+  const { refinements, dispatch, enableVideos } = useContext(SearchContext);
 
   // only bold the dropdown title if the learning type is Course or Program
   const typeCourseSelected = refinements.content_type && refinements.content_type.includes(LEARNING_TYPE_COURSE);
@@ -115,25 +115,24 @@ const LearningTypeRadioFacet = ({ enablePathways }) => {
               </Dropdown.Item>
             )
           }
-          {features.ENABLE_VIDEO_CATALOG
-            && (
-              <Dropdown.Item as="label" className="mb-0 py-3 d-flex align-items-center">
-                <Input
-                  type="radio"
-                  checked={typeVideoSelected}
-                  className="facet-item position-relative mr-2 mb-2"
-                  onChange={() => handleInputOnChange(LEARNING_TYPE_VIDEO)}
-                  data-testid="learning-type-videos"
-                />
-                <span className={classNames('facet-item-label', { 'is-refined': typeVideoSelected })}>
-                  <FormattedMessage
-                    id="search.facetFilters.learningType.videos"
-                    defaultMessage="Videos"
-                    description="Title for the learning type facet filter to return videos only"
-                  />
-                </span>
-              </Dropdown.Item>
-            )}
+          {enableVideos && (
+          <Dropdown.Item as="label" className="mb-0 py-3 d-flex align-items-center">
+            <Input
+              type="radio"
+              checked={typeVideoSelected}
+              className="facet-item position-relative mr-2 mb-2"
+              onChange={() => handleInputOnChange(LEARNING_TYPE_VIDEO)}
+              data-testid="learning-type-videos"
+            />
+            <span className={classNames('facet-item-label', { 'is-refined': typeVideoSelected })}>
+              <FormattedMessage
+                id="search.facetFilters.learningType.videos"
+                defaultMessage="Videos"
+                description="Title for the learning type facet filter to return videos only"
+              />
+            </span>
+          </Dropdown.Item>
+          )}
         </Dropdown.Menu>
       </Dropdown>
     </div>

diff --git a/packages/catalog-search/src/SearchContext.jsx b/packages/catalog-search/src/SearchContext.jsx
@@ -38,7 +38,9 @@ export const getRefinementsToSet = (queryParams, activeFacetAttributes) => {
   return refinementsToSet;
 };
 
-const SearchData = ({ children, searchFacetFilters, trackingName }) => {
+const SearchData = ({
+  children, searchFacetFilters, trackingName, enableVideos,
+}) => {
   const [refinements, dispatch] = useReducer(
     refinementsReducer,
     {},
@@ -83,8 +85,9 @@ const SearchData = ({ children, searchFacetFilters, trackingName }) => {
       dispatch,
       searchFacetFilters: searchFilters,
       trackingName,
+      enableVideos,
     }),
-    [JSON.stringify(refinements), dispatch, searchFilters, trackingName],
+    [JSON.stringify(refinements), dispatch, searchFilters, trackingName, enableVideos],
   );
 
   return (
@@ -95,6 +98,7 @@ const SearchData = ({ children, searchFacetFilters, trackingName }) => {
 SearchData.defaultProps = {
   searchFacetFilters: null,
   trackingName: null,
+  enableVideos: false,
 };
 
 SearchData.propTypes = {
@@ -105,6 +109,7 @@ SearchData.propTypes = {
     isSortedAlphabetical: PropTypes.bool,
   })),
   trackingName: PropTypes.string,
+  enableVideos: PropTypes.bool,
 };
 
 export default SearchData;
diff --git a/packages/catalog-search/src/config/index.js b/packages/catalog-search/src/config/index.js
@@ -6,7 +6,6 @@ export const FEATURE_PROGRAM_TITLES_FACET = 'PROGRAM_TITLES_FACET';
 export const LEARNING_TYPE_FACET = 'LEARNING_TYPE_FACET';
 export const FEATURE_ENABLE_PATHWAYS = 'ENABLE_PATHWAYS';
 export const FEATURE_SUBTITLE_FACET = 'SUBTITLE_FACET';
-export const FEATURE_ENABLE_VIDEO_CATALOG = 'FEATURE_ENABLE_VIDEO_CATALOG';
 
 // eslint-disable-next-line import/prefer-default-export
 export const features = {
@@ -24,7 +23,4 @@ export const features = {
   SUBTITLE_FACET: (
     process.env.FEATURE_SUBTITLE_FACET || hasFeatureFlagEnabled(FEATURE_SUBTITLE_FACET)
   ),
-  ENABLE_VIDEO_CATALOG: (
-    process.env.FEATURE_ENABLE_VIDEO_CATALOG || hasFeatureFlagEnabled(FEATURE_ENABLE_VIDEO_CATALOG)
-  ),
 };