Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade 'sass' to 1.85.1, silence new deprecation warnings #630

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Upgrade 'sass' to 1.85.1, silence new deprecation warnings #630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion config/webpack.dev-stage.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,9 @@ module.exports = merge(commonConfig, {
path.join(process.cwd(), 'node_modules'),
path.join(process.cwd(), 'src'),
],
// silences compiler warnings regarding deprecation warnings
// Silences compiler deprecation warnings. They mostly come from bootstrap and/or paragon.
quietDeps: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, do you happen to know why the quietDeps: true doesn't seem to handle the silencing of deprecations on its own?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't. I probably should have investigated more; my hunch is that the quietDeps parameter was replaced with the more fine-grained silenceDeprecations option at some point. But I left it there since I wasn't sure if it's silencing some other warnings or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, OK that was wrong. Per https://sass-lang.com/documentation/js-api/interfaces/options/#quietDeps quietDeps means "If this option is set to true, Sass won’t print warnings that are caused by dependencies." - but we're still seeing warnings here from imports of paragon and bootstrap CSS which technically isn't a dependency. Maybe I should look a bit closer and see if it's actually something fixable.

Copy link
Contributor Author

@bradenmacdonald bradenmacdonald Feb 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, I did try to run npx sass-migrator module src/**/*.scss in the Learning MFE, but it says that it can't migrate the imports without modifying dependency files like node_modules/bootstrap/scss/_functions.scss . So that's why I decided to just silence them for now.

silenceDeprecations: ['abs-percent', 'color-functions', 'import', 'mixed-decls', 'global-builtin'],
},
},
},
Expand Down
3 changes: 2 additions & 1 deletion config/webpack.dev.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,9 @@ function getStyleUseConfig() {
path.join(process.cwd(), 'node_modules'),
path.join(process.cwd(), 'src'),
],
// silences compiler warnings regarding deprecation warnings
// Silences compiler deprecation warnings. They mostly come from bootstrap and/or paragon.
quietDeps: true,
silenceDeprecations: ['abs-percent', 'color-functions', 'import', 'mixed-decls', 'global-builtin'],
},
},
},
Expand Down
3 changes: 2 additions & 1 deletion config/webpack.prod.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,9 @@ module.exports = merge(commonConfig, {
path.join(process.cwd(), 'node_modules'),
path.join(process.cwd(), 'src'),
],
// silences compiler warnings regarding deprecation warnings
// Silences compiler deprecation warnings. They mostly come from bootstrap and/or paragon.
quietDeps: true,
silenceDeprecations: ['abs-percent', 'color-functions', 'import', 'mixed-decls', 'global-builtin'],
},
},
},
Expand Down
Loading