Upgrade 'sass' to 1.85.1, silence new deprecation warnings #630
Conversation
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
|
@adamstankiewicz @brian-smith-tcril could I please get a review of this from one of you? |
|
Thanks @adamstankiewicz ! I thought your review would turn this green - is there a permissions issue here or do I need another reviewer? |
| @@ -100,8 +100,9 @@ module.exports = merge(commonConfig, { | |||
| path.join(process.cwd(), 'node_modules'), | |||
| path.join(process.cwd(), 'src'), | |||
| ], | |||
| // silences compiler warnings regarding deprecation warnings | |||
| // Silences compiler deprecation warnings. They mostly come from bootstrap and/or paragon. | |||
| quietDeps: true, | |||
There was a problem hiding this comment.
Out of curiosity, do you happen to know why the quietDeps: true doesn't seem to handle the silencing of deprecations on its own?
There was a problem hiding this comment.
I don't. I probably should have investigated more; my hunch is that the quietDeps parameter was replaced with the more fine-grained silenceDeprecations option at some point. But I left it there since I wasn't sure if it's silencing some other warnings or not.
There was a problem hiding this comment.
Oh, OK that was wrong. Per https://sass-lang.com/documentation/js-api/interfaces/options/#quietDeps quietDeps means "If this option is set to true, Sass won’t print warnings that are caused by dependencies." - but we're still seeing warnings here from imports of paragon and bootstrap CSS which technically isn't a dependency. Maybe I should look a bit closer and see if it's actually something fixable.
There was a problem hiding this comment.
Oh yeah, I did try to run npx sass-migrator module src/**/*.scss in the Learning MFE, but it says that it can't migrate the imports without modifying dependency files like node_modules/bootstrap/scss/_functions.scss . So that's why I decided to just silence them for now.
I unfortunately lost write permissions on most of the frontend repositories recently, due to some permissions and core contributor changes between 2U/Axim. Hope to get it back soon enough. |
|
@brian-smith-tcril Could I please get a look here from you too in that case? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #630 +/- ##
=============================
=============================
☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 14.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 15.0.0-alpha.25 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This upgrades
sassand silences the many deprecation warnings that result.Without this, MFEs may bump the sass version anyways, and then they'll see this ugliness when starting the dev server: