feat: skip staff checks on publisher for Bootcamps

openedx · Jun 1, 2022 · 20b4ada · 20b4ada
1 parent da2c3f2
commit 20b4ada
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 1 deletion.
diff --git a/src/utils/validation.js b/src/utils/validation.js
@@ -103,7 +103,12 @@ const editCourseValidate = (values, props) => {
         && registeredFields['prices.paid-executive-education']
         && registeredFields['prices.paid-executive-education'].count;
 
-      const runRequiredFields = isExecutiveEducation ? ['transcript_languages'] : ['transcript_languages', 'staff'];
+      // naive check to deteremine if track is bootcamp or not
+      const isBootcamp = registeredFields
+        && registeredFields['prices.paid-bootcamp']
+        && registeredFields['prices.paid-bootcamp'].count;
+
+      const runRequiredFields = (isExecutiveEducation || isBootcamp) ? ['transcript_languages'] : ['transcript_languages', 'staff'];
       const runErrors = {};
       runRequiredFields.forEach((fieldName) => {
         const value = run[fieldName];

diff --git a/src/utils/validation.test.js b/src/utils/validation.test.js
@@ -248,4 +248,34 @@ describe('editCourseValidate', () => {
       },
     })).toEqual({});
   });
+  it('returns no error on submitting 2U bootcamp runs with missing staff', () => {
+    const values = {
+      short_description: 'Short',
+      full_description: 'Full',
+      outcome: 'Outcome',
+      imageSrc: 'base64;encodedimage',
+      course_runs: [
+        {
+          key: 'NonSubmittingTestRun',
+        },
+        {
+          key: 'TestRun',
+          transcript_languages: [
+            {
+              dummy_field: 'Transcript languages dummy field',
+            },
+          ],
+          staff: [],
+        },
+      ],
+    };
+    expect(editCourseValidate(values, {
+      targetRun: unpublishedTargetRun,
+      registeredFields: {
+        'prices.paid-bootcamp': {
+          count: 1,
+        },
+      },
+    })).toEqual({});
+  });
 });